Skip to content

Rename getMountingLogs as takeMountingManagerLogs#49015

Closed
rubennorte wants to merge 1 commit into
facebook:mainfrom
rubennorte:export-D67549202
Closed

Rename getMountingLogs as takeMountingManagerLogs#49015
rubennorte wants to merge 1 commit into
facebook:mainfrom
rubennorte:export-D67549202

Conversation

@rubennorte
Copy link
Copy Markdown
Contributor

@rubennorte rubennorte commented Jan 28, 2025

Summary:
Changelog: [internal]

This name better reflects the fact that we're emptying the buffer when calling it.

Differential Revision: D67549202

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jan 28, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 28, 2025

This pull request was exported from Phabricator. Differential Revision: D67549202

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 28, 2025

This pull request was exported from Phabricator. Differential Revision: D67549202

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 28, 2025

This pull request was exported from Phabricator. Differential Revision: D67549202

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 29, 2025

This pull request was exported from Phabricator. Differential Revision: D67549202

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 29, 2025

This pull request was exported from Phabricator. Differential Revision: D67549202

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 29, 2025

This pull request was exported from Phabricator. Differential Revision: D67549202

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 29, 2025

This pull request was exported from Phabricator. Differential Revision: D67549202

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 29, 2025

This pull request was exported from Phabricator. Differential Revision: D67549202

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 29, 2025

This pull request was exported from Phabricator. Differential Revision: D67549202

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 29, 2025

This pull request was exported from Phabricator. Differential Revision: D67549202

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 29, 2025

This pull request was exported from Phabricator. Differential Revision: D67549202

@rubennorte @facebook-github-bot
Rename getMountingLogs as takeMountingManagerLogs (facebook#49015)
1515710 
Summary:

Changelog: [internal]

This name better reflects the fact that we're emptying the buffer when calling it.

Reviewed By: javache

Differential Revision: D67549202
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 29, 2025

This pull request was exported from Phabricator. Differential Revision: D67549202

@react-native-bot
Copy link
Copy Markdown
Collaborator

react-native-bot commented Jan 29, 2025

This pull request was successfully merged by @rubennorte in fb9b476

When will my fix make it into a release? | How to file a pick request?

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rubennorte @facebook-github-bot @react-native-bot